Skip to content

Conversation

@dariakp
Copy link
Contributor

@dariakp dariakp commented Dec 16, 2025

Description

Summary of Changes

This PR annotates our withTransaction implementation with exact spec text prior to backpressure changes introduced in https://github.com/mongodb/specifications/pull/1851/files

Notes for Reviewers

Our implementation seems fully accurate relative to spec, other than the preemptive abort called out in the corresponding comment and the CSOT handling that didn't make it into this part of the spec.

What is the motivation for this change?

Make it easier to review the changes in #4765 for accuracy.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp marked this pull request as ready for review December 16, 2025 19:23
@dariakp dariakp requested a review from a team as a code owner December 16, 2025 19:23
@dariakp dariakp merged commit c990750 into main Dec 16, 2025
24 of 28 checks passed
@dariakp dariakp deleted the transaction-annotations branch December 16, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants