chore(NODE-7767): snappy 7.4 is incompatible in CI - #5021
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins snappy in Evergreen CI to avoid snappy@7.4.0 breaking test runs, and updates the driver’s dependency constraints to prevent pulling the known-bad version while preserving optional peer dependency behavior.
Changes:
- Pins
snappy@7.3.3in.evergreen/run-tests.shwith a TODO to remove the pin later. - Replaces
snappy’s previous^7.3.2range with a comparison/OR range intended to exclude7.4.0. - Updates
package-lock.jsonto reflect the newsnappyrange in root dependency metadata.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
package.json |
Narrows/adjusts snappy peer + dev dependency ranges to avoid the incompatible release. |
package-lock.json |
Updates lock metadata to match the new snappy range declarations. |
.evergreen/run-tests.sh |
Pins CI install of snappy to a known-good version to unblock Evergreen runs. |
Suppressed comments (1)
package.json:107
- Same as the peerDependency entry above: this range both allows future major versions (>7) and only excludes 7.4.0 specifically. Consider keeping the major pinned (<8.0.0) while excluding 7.4.0 via
>=7.4.1.
"sinon": "^18.0.1",
"sinon-chai": "^4.0.1",
"snappy": ">=7.3.2 <7.4.0 || >7.4.0",
"socks": "^2.8.7",
"source-map-support": "^0.5.21",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
johnmtll
force-pushed
the
pin-snappy-ci
branch
from
August 12, 2026 20:11
0e6f5ea to
e0875a8
Compare
johnmtll
force-pushed
the
pin-snappy-ci
branch
from
August 12, 2026 21:36
377d5dd to
c0d5032
Compare
PavelSafronov
left a comment
Contributor
There was a problem hiding this comment.
The description of the PR doesn't match the content, please update it, so this doesn't confuse future devs.
PavelSafronov
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Snappy@7.4.0 is incompatible with the driver and is breaking our CI. These changes will pin snappy to a compatible version explicitly in our CI, and include a callout to remove the pin at a later date.
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript