Skip to content

chore(NODE-7767): snappy 7.4 is incompatible in CI - #5021

Merged
PavelSafronov merged 5 commits into
mainfrom
pin-snappy-ci
Aug 13, 2026
Merged

chore(NODE-7767): snappy 7.4 is incompatible in CI#5021
PavelSafronov merged 5 commits into
mainfrom
pin-snappy-ci

Conversation

@johnmtll

@johnmtll johnmtll commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

Summary of Changes

Snappy@7.4.0 is incompatible with the driver and is breaking our CI. These changes will pin snappy to a compatible version explicitly in our CI, and include a callout to remove the pin at a later date.

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@johnmtll
johnmtll marked this pull request as ready for review August 12, 2026 19:35
@johnmtll
johnmtll requested a review from a team as a code owner August 12, 2026 19:35
Copilot AI lite review requested due to automatic review settings August 12, 2026 19:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins snappy in Evergreen CI to avoid snappy@7.4.0 breaking test runs, and updates the driver’s dependency constraints to prevent pulling the known-bad version while preserving optional peer dependency behavior.

Changes:

  • Pins snappy@7.3.3 in .evergreen/run-tests.sh with a TODO to remove the pin later.
  • Replaces snappy’s previous ^7.3.2 range with a comparison/OR range intended to exclude 7.4.0.
  • Updates package-lock.json to reflect the new snappy range in root dependency metadata.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Narrows/adjusts snappy peer + dev dependency ranges to avoid the incompatible release.
package-lock.json Updates lock metadata to match the new snappy range declarations.
.evergreen/run-tests.sh Pins CI install of snappy to a known-good version to unblock Evergreen runs.
Suppressed comments (1)

package.json:107

  • Same as the peerDependency entry above: this range both allows future major versions (>7) and only excludes 7.4.0 specifically. Consider keeping the major pinned (<8.0.0) while excluding 7.4.0 via >=7.4.1.
    "sinon": "^18.0.1",
    "sinon-chai": "^4.0.1",
    "snappy": ">=7.3.2 <7.4.0 || >7.4.0",
    "socks": "^2.8.7",
    "source-map-support": "^0.5.21",

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
Comment thread .evergreen/run-tests.sh Outdated
@johnmtll johnmtll changed the title ci: snappy 7.4 is incompatible chore(NODE-7767): snappy 7.4 is incompatible Aug 12, 2026
@johnmtll johnmtll changed the title chore(NODE-7767): snappy 7.4 is incompatible chore(NODE-7767): snappy 7.4 is incompatible in CI Aug 12, 2026
@PavelSafronov PavelSafronov self-assigned this Aug 13, 2026
@PavelSafronov PavelSafronov added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 13, 2026
Comment thread .evergreen/run-tests.sh Outdated
Comment thread test/action/dependency.test.ts

@PavelSafronov PavelSafronov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of the PR doesn't match the content, please update it, so this doesn't confuse future devs.

@johnmtll
johnmtll requested a review from PavelSafronov August 13, 2026 18:13
@PavelSafronov
PavelSafronov merged commit bc92c29 into main Aug 13, 2026
33 checks passed
@PavelSafronov
PavelSafronov deleted the pin-snappy-ci branch August 13, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants