Skip to content

DRIVERS-3106 revise fle2v2-BypassQueryAnalysis #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 19, 2025

Conversation

mdb-ad
Copy link
Contributor

@mdb-ad mdb-ad commented Apr 25, 2025

#1756 accidentally used outcome matching in fle2v2-BypassQueryAnalysis which is not supported by the spec. This PR replaces it with a find on an unencrypted client.

Edit: also revise poc-queryable-encryption

C driver PR: mongodb/mongo-c-driver#2004

@mdb-ad mdb-ad requested a review from a team as a code owner April 25, 2025 18:09
@mdb-ad mdb-ad requested review from katcharov and removed request for a team April 25, 2025 18:09
@mdb-ad mdb-ad requested a review from a team as a code owner April 25, 2025 18:37
@mdb-ad mdb-ad requested review from jmikola and removed request for a team April 25, 2025 18:37
@kevinAlbs kevinAlbs requested review from jyemin and kevinAlbs and removed request for katcharov April 25, 2025 18:42
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Suggest adding rationale and linking to a C driver PR for others to reference.

@jyemin jyemin requested review from rozza and removed request for jmikola and jyemin April 28, 2025 13:36
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe poc-queryable-encryption.yml also requires updating.

@mdb-ad mdb-ad requested review from rozza and kevinAlbs May 8, 2025 00:22
Copy link
Contributor

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments. Suggest running git merge master to get recent fixes to GitHub actions: #1797

Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdb-ad mdb-ad merged commit 1c1500a into mongodb:master May 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants