test: Adds collection restore job acceptance tests

[EspenAlbert]

Description

Adds acceptance tests for mongodbatlas_cloud_backup_collection_restore_job and snapshot database data sources, plus a shared fixture that provisions a backup-enabled source cluster and on-demand snapshot. CI gets a backup_collection_restore test group.

Link to any related issue(s): CLOUDP-435981

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contributing guides
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fix and verified my code
• If changes include deprecations or removals I have added appropriate changelog entries.
• If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

External reuse is supported via MONGODB_ATLAS_PROJECT_ID, MONGODB_ATLAS_CLUSTER_NAME, and MONGODB_ATLAS_SNAPSHOT_ID. The execution cluster helper can enable cloud backup and PIT when the fixture creates it.

[Copilot]

Pull request overview

Adds a shared acceptance-test fixture and new acceptance tests to validate Atlas Cloud Backup collection restore jobs and snapshot database/collection discovery, and wires them into CI via a dedicated backup_collection_restore test group.

Changes:

• Introduces a reusable fixture that provisions (or reuses via env vars) a backup/PIT-enabled source cluster plus an on-demand snapshot, along with helper pollers for collection-restore jobs.
• Adds new acceptance tests for mongodbatlas_cloud_backup_collection_restore_job and snapshot database/collection data sources.
• Extends the acceptance test runner workflow to include a backup_collection_restore change-detection group and job.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/testutil/acc/shared_resource.go	Adds internal helper to create an execution cluster with backup/PIT toggles for fixture-driven tests.
internal/testutil/acc/cloud_backup_collection_restore_fixture.go	New shared fixture and helper functions for collection-restore acceptance tests (snapshot creation, job polling, env reuse).
internal/testutil/acc/cloud_backup_collection_restore_fixture_test.go	Unit tests for fixture helper functions (env parsing, timestamp conversion, backup/PIT flag checks).
internal/testutil/acc/atlas.go	Extends cluster creation helpers to allow enabling cloud backup and PIT for fixture-created clusters.
internal/serviceapi/cloudbackupsnapshotdatabase/main_test.go	Adds TestMain to run acceptance harness for the snapshot database acceptance test package.
internal/serviceapi/cloudbackupsnapshotdatabase/data_source_test.go	Adds acceptance coverage for snapshot database and database-collections discovery data sources.
internal/serviceapi/cloudbackupcollectionrestorejob/resource_test.go	Adds acceptance coverage for collection restore job resource + related data sources (incl. PIT and timeout behaviors).
internal/serviceapi/cloudbackupcollectionrestorejob/main_test.go	Adds TestMain to run acceptance harness for the restore job acceptance test package.
.github/workflows/acceptance-tests-runner.yml	Adds backup_collection_restore change-detection filter and a dedicated acceptance-test job.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Suppressed comments (1)

internal/testutil/acc/cloud_backup_collection_restore_fixture.go:254

• Same response-body leak pattern as GetCollectionRestoreJob: on HTTP errors UntypedAPICall returns (resp, err) and the body should be closed before returning.

func LatestCollectionRestoreJobID(ctx context.Context, projectID, clusterName, destClusterName string) (string, error) {
	resp, err := MongoDBClient.UntypedAPICall(ctx, collectionRestoreJobCall(projectID, clusterName, ""), nil)
	if err != nil {
		return "", err
	}

[augmentcode]

🤖 Augment PR Summary

Summary: Adds acceptance coverage for collection-level cloud backup restores and snapshot namespace discovery.

• Adds same-cluster snapshot restore coverage for database renames and collection restore results.
• Adds cross-cluster point-in-time restore coverage using database and collection suffixes.
• Adds an invalid source-collection scenario and a short create-timeout cleanup scenario.
• Introduces a process-wide fixture for a backup- and PIT-enabled source cluster with sample data.
• Allows the fixture to reuse a supplied project, cluster, and completed snapshot through environment variables.
• Adds helpers to discover and wait for collection restore jobs through the versioned Atlas API.
• Adds snapshot database and collection discovery data-source acceptance coverage.
• Extends generated advanced-cluster test HCL to support an explicit electable-node disk size.
• Extends cluster creation helpers to request cloud backup and PIT when needed.
• Adds a dedicated CI change-detection group and acceptance-test job for this coverage.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[EspenAlbert]

Need to fix the change in the plural data source

[EspenAlbert]

Tests fixed, and all checks passing again:
ok github.com/mongodb/terraform-provider-mongodbatlas/internal/serviceapi/cloudbackupcollectionrestorejob2951.963s

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[AgustinBettati]

q: A lot of code here seems associated to triggering and handling a restore job, couldnt we use the TF resource for this?

[EspenAlbert]

Happy-path tests already POST through the TF resource. These helpers only GET/poll.

We still need them because:

• Delete is a no-op (no public cancel API)
• A timed-out create never records job_id, so Terraform state is empty
• CheckDestroy has to find that leftover job and wait until dest-cluster teardown reaches CANCELED

[AgustinBettati]

LGTM

[AgustinBettati]

nice!