chore: Add resource schema hooks and fix ip access list semantics - #4679
Open
laylaazouz wants to merge 4 commits into
Open
chore: Add resource schema hooks and fix ip access list semantics#4679laylaazouz wants to merge 4 commits into
laylaazouz wants to merge 4 commits into
Conversation
laylaazouz
marked this pull request as ready for review
August 26, 2026 13:05
Contributor
|
APIx bot: a message has been sent to Docs Slack channel |
🤖 Augment PR SummarySummary: This PR aligns MCP configuration IP access-list handling with the API's unordered semantics.
🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
| ip, hasIP := entry["ipAddress"].(string) | ||
| cidr, hasCIDR := entry["cidrBlock"].(string) | ||
| if hasIP && hasCIDR && ip != "" && cidr == ip+"/32" { |
There was a problem hiding this comment.
At internal/serviceapi/mcpconfig/resource_custom_hooks.go:64, this only recognizes an echoed IPv4 host CIDR (/32), but ip_address also supports IPv6, whose equivalent echoed CIDR is /128. A subsequent update of an IPv6-backed configuration can therefore submit both fields, which the API rejects as mutually exclusive.
Severity: medium
Other Locations
internal/serviceapi/projectmcpconfig/resource_custom_hooks.go:64
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ip_access_listonmongodbatlas_mcp_configandmongodbatlas_project_mcp_config(and their data sources) from a list toa set
the Atlas API.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments