Skip to content

Migrate Danger to use danger-pr-comment workflow - #15

Closed
dblock wants to merge 1 commit into
mongoid:masterfrom
dblock:master
Closed

dblock wants to merge 1 commit into
mongoid:masterfrom
dblock:master

Conversation

@dblock

@dblock dblock commented Dec 31, 2025

Copy link
Copy Markdown

Summary

  • Replace mongoid-danger with danger, danger-changelog, and danger-pr-comment gems
  • Update Dangerfile to import danger-pr-comment and include changelog.check!
  • Add GitHub workflows for Danger integration using reusable workflows from numbata/danger-pr-comment

This migration follows the pattern established in related projects:

Test plan

  • Verify PR checks run successfully
  • Verify Danger comments appear on PRs
  • Verify changelog validation works correctly

🤖 Generated with Claude Code

- Replace mongoid-danger with danger, danger-changelog, and danger-pr-comment gems
- Update Dangerfile to import danger-pr-comment and include changelog.check!
- Add GitHub workflows for Danger integration using reusable workflows

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dblock

dblock commented Dec 31, 2025

Copy link
Copy Markdown
Author

Need to migrate CI to GHA first.

@dblock

dblock commented Oct 16, 2026

Copy link
Copy Markdown
Author

Superseded by #18, which carries this migration on current master, keeps modern Danger dependencies out of legacy Ruby jobs, and uses Ruby 3.3 for the Danger workflow. A dedicated branch avoids force-pushing the original fork master branch. Closing this PR in favor of that unmerged replacement.

Posted by an AI on behalf of @dblock.

@dblock dblock closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant