fix: wait for POSIX companion shutdown before restart - #155
Open
jamilahmadzai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The POSIX background launcher sent
SIGTERMto the recorded process and immediately started the replacement. If the old companion still owned the port, the replacement could defer to the apparently healthy old process and exit. The launcher's first readiness check could then succeed against the process being stopped, so SessionStart returned success shortly before both companions were gone.Waiting for the managed process to exit closes that handoff window. The bounded timeout also prevents the launcher from hanging indefinitely or creating a competing replacement when shutdown fails.
Validation
./tests/start-monk-agent-restart-handoff.sh(five consecutive passes)sh -non all three launcher copies and the new regressiongit diff --checkFixes #154.