fix: retry Linux background launcher after early exit - #182
Open
jamilahmadzai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The macOS path delegates non-zero agent exits to launchd
KeepAlive, but the Linux/background path started the child once. If that child exited before the health endpoint became ready, the launcher observed the dead PID, stopped waiting, and returned a not-ready error without giving the agent another chance to recover.The retry stays limited by
MONK_AGENT_BACKGROUND_RESTARTSwith a small default and the existing readiness deadline, so persistent failures still terminate cleanly.Validation
./tests/start-monk-agent-background-retry.sh./tests/start-monk-agent-readiness-timeout.sh./tests/start-monk-agent-fastpath.shsh -n scripts/start-monk-agent.sh plugins/monk/scripts/start-monk-agent.sh .antigravity-plugin/scripts/start-monk-agent.sh tests/start-monk-agent-background-retry.sh tests/start-monk-agent-readiness-timeout.sh tests/start-monk-agent-fastpath.shcmp.github/workflows/install-e2e.ymlgit diff --checkFixes #180.