fix launcher telemetry JSON escaping - #189
Open
jhontejada95 wants to merge 1 commit into
Open
Conversation
jhontejada95
marked this pull request as ready for review
July 30, 2026 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_msanfilter with a POSIXod/awkJSON string encoder0x00–0x1fcontrol byte while preserving UTF-8Root cause
The POSIX launcher builds its early PostHog payload by hand. Its sanitizer deleted quotes, backslashes, CR, and LF, but left tabs and other control bytes in JSON strings. Those bytes make the payload invalid, while deleting valid characters also silently changed telemetry values.
Impact
Dynamic launcher properties containing quotes, slashes, whitespace controls, or UTF-8 now remain valid and round-trip without data loss, preventing affected telemetry events from being corrupted or dropped.
Validation
./tests/monk-launcher-telemetry-json.shsh -non all three telemetry scripts and the regression test./tests/start-monk-agent-fastpath.sh./tests/start-monk-agent-readiness-timeout.shgit diff --checkFixes #179