Skip to content

feat(quotes): Add custom length filter (@Leonabcd123) #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

feat(quotes): Add custom length filter (@Leonabcd123) #7109

wants to merge 29 commits into from
+120 −3

Conversation

@Leonabcd123
Copy link
Contributor

@Leonabcd123 Leonabcd123 commented Nov 15, 2025 •
edited
Loading

Description

Added a new filter option in the quotes search page that allows the user to search for quotes by a minimum and a maximum length.

Implementing #1323

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Nov 15, 2025
fehmer
fehmer reviewed Nov 15, 2025
View reviewed changes
Miodec
Miodec reviewed Nov 26, 2025
View reviewed changes
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 26, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 26, 2025
@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 26, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 27, 2025
@Leonabcd123 Leonabcd123 requested a review from Miodec November 27, 2025 18:41
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Nov 27, 2025
@Miodec
Copy link
Member

Miodec commented Nov 27, 2025

If you open the custom modal and then close it by clicking outside of it, it should clear the filter box, otherwise you get no results with the custom filter still selected
image

@Leonabcd123
Copy link
Contributor Author

Leonabcd123 commented Nov 27, 2025 •
edited
Loading

Just used hideCallsExec to force users to enter min and max values.

@Miodec
Copy link
Member

Miodec commented Nov 27, 2025 •
edited
Loading

Just used hideCallsExec to force users to enter min and max values.

From a user experience point, i would rather have the ability to cancel out of the modal, instead of being forced to fill in the values.

@Leonabcd123
Copy link
Contributor Author

Leonabcd123 commented Nov 28, 2025 •
edited
Loading

afterClickAway is now called after we click out of the modal. It seems that customWrapperClickHandler can only be defined for animated modals, so I added support for it in simple modals via afterClickAway.

@Leonabcd123
Copy link
Contributor Author

Leonabcd123 commented Nov 28, 2025

Should be good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fehmer fehmer fehmer left review comments

@Miodec Miodec Awaiting requested review from Miodec

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Leonabcd123 @Miodec @fehmer @monkeytypegeorge