Skip to content

Dispose temporary vertices in SKCanvas.DrawVertices #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dispose temporary vertices in SKCanvas.DrawVertices #3319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions binding/SkiaSharp/SKCanvas.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,25 +911,25 @@ public SKMatrix44 TotalMatrix44 {

public void DrawVertices (SKVertexMode vmode, SKPoint[] vertices, SKColor[] colors, SKPaint paint)
{
var vert = SKVertices.CreateCopy (vmode, vertices, colors);
using var vert = SKVertices.CreateCopy (vmode, vertices, colors);
DrawVertices (vert, SKBlendMode.Modulate, paint);
}

public void DrawVertices (SKVertexMode vmode, SKPoint[] vertices, SKPoint[] texs, SKColor[] colors, SKPaint paint)
{
var vert = SKVertices.CreateCopy (vmode, vertices, texs, colors);
using var vert = SKVertices.CreateCopy (vmode, vertices, texs, colors);
DrawVertices (vert, SKBlendMode.Modulate, paint);
}

public void DrawVertices (SKVertexMode vmode, SKPoint[] vertices, SKPoint[] texs, SKColor[] colors, UInt16[] indices, SKPaint paint)
{
var vert = SKVertices.CreateCopy (vmode, vertices, texs, colors, indices);
using var vert = SKVertices.CreateCopy (vmode, vertices, texs, colors, indices);
DrawVertices (vert, SKBlendMode.Modulate, paint);
}

public void DrawVertices (SKVertexMode vmode, SKPoint[] vertices, SKPoint[] texs, SKColor[] colors, SKBlendMode mode, UInt16[] indices, SKPaint paint)
{
var vert = SKVertices.CreateCopy (vmode, vertices, texs, colors, indices);
using var vert = SKVertices.CreateCopy (vmode, vertices, texs, colors, indices);
DrawVertices (vert, mode, paint);
}

Expand Down