Conversation
Coverage Report for CI Build 244Coverage decreased (-1.5%) to 77.055%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds file system watching support for
moonbitlang/async/fs. The goal is to provide API with consistent behavior & simple interface on all platforms. To achieve this goal, some hard works are done internally to uniting the platform differences between the underlying OS primitives, performing rename detection, etc. Under the hood,inotifyis used on Linux,kqueuewithEVFILT_VNODEis used on MacOS, andReadDirectoryChangesWis used on Windows.Currently only recursive directory watching is supported. Shallow directory watching may be added in the future, while single file watching seems difficult on Windows.
For behavior details, see the document for
@fs.FsEventand@fs.Watcher::Watcher. Some feature highlights:inotifyandReadDirectoryChangesWmay overflow when there are too many events. Here@fs.Watchertry to avoid such overflow by:Create/Remove/Renameoperations are properly reported, and the file hierarchy of the watched tree can be properly rebuilt. The user will still receive aOverflowevent in this case, indicating that the content of all watched files may have changed