Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a75e7a20c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
myfreess
force-pushed
the
use_cst
branch
3 times, most recently
from
daef7d4 to
2f655d0
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f655d0afa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bindings=acc, | ||
| body=cont, | ||
| loc=Location::merge(loc, loc_of_expression(cont)), | ||
| fn_locs=fn_locs.rev(), |
There was a problem hiding this comment.
When two or more local fn statements are compacted into a LetRec, acc is already in source order because it is built with the same add sequence used by the previous implementation for bindings; reversing only fn_locs makes the keyword-location list run opposite to bindings. For a block like fn f() {}; fn g() {}; body, CST consumers that align fn_locs with bindings will associate g's fn location with f and vice versa.
Useful? React with 👍 / 👎.
1 participant
No description provided.