t/basics/definition_context.t - adapt for improved line number reporting#188
Open
richardleach wants to merge 1 commit into
Open
t/basics/definition_context.t - adapt for improved line number reporting#188richardleach wants to merge 1 commit into
richardleach wants to merge 1 commit into
Conversation
…eporting Early in the next development cycle of the perl interpreter, an attempt will be made to improve the inaccuracy of line number reporting by warnings/error and caller(), starting with: Perl/perl5#24387 - starting statement in elsif() blocks Perl/perl5#24389 - loop condition statements Perl/perl5#24396 - mid-statement anon sub declarations These changes break one test in this module written to match a specific emitted line number. This commit should ensure that the affected test succeeds regardless of whether the perl version in use demonstrates the older, buggier behaviour or the behaviour once the above pull requests are merged. (This would also reduce churn if those PRs are merged and present in some tagged releases, but then later reverted.)
richardleach
force-pushed
the
5.45.0_line_numbers
branch
from
f0eba01 to
3cfeca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early in the next development cycle of the perl interpreter, an attempt will be made to improve the inaccuracy of line number reporting by warnings/error and caller(), starting with:
These changes break one test in this module written to match a specific emitted line number.
This commit should ensure that the affected test succeeds regardless of whether the perl version in use demonstrates the older, buggier behaviour or the behaviour once the above pull requests are merged. (This would also reduce churn if those PRs are merged and present in some tagged releases, but then later reverted.)