Skip to content

fix: unavailable date json values #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: unavailable date json values #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/utils/time.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ func (ct *Time) UnmarshalJSON(b []byte) (err error) {

// MarshalJSON writes a quoted string in the custom format
func (ct Time) MarshalJSON() ([]byte, error) {
if ct.IsZero() {
return []byte("\"\""), nil
}

return []byte(ct.String()), nil
}

Expand Down
18 changes: 18 additions & 0 deletions pkg/utils/time_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2020 The Moov Authors
// Use of this source code is governed by an Apache License
// license that can be found in the LICENSE file.

package utils

import (
"bytes"
"testing"
)

func TestMarshalJSONIsZeroDate(t *testing.T) {
ct := new(Time) // create zero time
str, _ := ct.MarshalJSON()
if !bytes.Equal(str, []byte("\"\"")) {
t.Error("Expected empty string but received: \"" + string(str) + "\"\n")
}
}