Fixed issue where start function in HTTPConnection would freeze the UI thread in iOS apps.
#308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't seem like the issue this change is trying to fix was thoroughly researched and root caused. I am pretty sure this change breaks a bunch of scenarios. Please open a bug and include logs at the debug level to make it possible to understand the issue. I can't merge it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self explanatory. I am unsure why that was happening as I did not dig deep enough into the codebase. But the simplest solution was to put the connect logic into an asynchronous task.
I'd be thankful if this could get tested and released :)