Increase float precision when printing

To avoid scientific notation. Fixes #175
morganstanley · Jul 16, 2024 · 65a5e3c · 65a5e3c
1 parent 6e69906
commit 65a5e3c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/include/binlog/detail/OstreamBuffer.cpp b/include/binlog/detail/OstreamBuffer.cpp
@@ -47,14 +47,14 @@ OstreamBuffer& OstreamBuffer::operator<<(bool b)
 OstreamBuffer& OstreamBuffer::operator<<(double v)
 {
   reserve(64);
-  _p += snprintf(_p, 64, "%g", v);
+  _p += snprintf(_p, 64, "%.16g", v);
   return *this;
 }
 
 OstreamBuffer& OstreamBuffer::operator<<(long double v)
 {
   reserve(128);
-  _p += snprintf(_p, 128, "%Lg", v);
+  _p += snprintf(_p, 128, "%.16Lg", v);
   return *this;
 }
 

diff --git a/test/integration/LoggingFundamentals.cpp b/test/integration/LoggingFundamentals.cpp
@@ -21,6 +21,13 @@ void logUnsigned()
   BINLOG_INFO("{} {} {} {}", a, b, c, T(40));
 }
 
+template <typename T>
+void logDouble()
+{
+  T f = 1234234.0234242;
+  BINLOG_INFO("{}", f);
+}
+
 int main()
 {
   logSigned<signed short>(); // NOLINT
@@ -66,6 +73,11 @@ int main()
   // Outputs: -20 30 30 -40
   // Outputs: -20 30 30 -40
 
+  logDouble<double>();
+  logDouble<long double>();
+  // Outputs: 1234234.0234242
+  // Outputs: 1234234.0234242
+
   char c = 'A';
   const char cc = 'B';
   const char& ccr = 'C';