fix(bundler): sweep srcToken after Paraswap_Sell with sellEntireBalance#519
Merged
fix(bundler): sweep srcToken after Paraswap_Sell with sellEntireBalance#519
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Foulks-Plb
previously approved these changes
Mar 9, 2026
oumar-fall
previously approved these changes
Mar 9, 2026
…ap_Sell When sellEntireBalance=true, leftover srcToken was not swept from paraswapAdapter back to generalAdapter1, leaving it stealable via permissionless Bundler3 multicall. Now sweeps unconditionally, matching Paraswap_Buy and Blue_Paraswap_BuyDebt. Resolves SDK-92 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verify that encodeOperation always includes the erc20Transfer sweep of srcToken from paraswapAdapter back to generalAdapter1, regardless of sellEntireBalance. This test fails without the fix from the previous commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rubilmax
force-pushed
the
Rubilmax/fix-paraswap-sweep
branch
from
4357abc to
23d2ddb
Compare
Foulks-Plb
approved these changes
Mar 9, 2026
oumar-fall
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
srcTokenfromparaswapAdapterback togeneralAdapter1afterParaswap_Sell, regardless ofsellEntireBalancesellEntireBalance=true, the sweep was skipped, leaving unswapped tokens stranded on the adapter where they could be stolen via permissionlessBundler3.multicallParaswap_BuyandBlue_Paraswap_BuyDebt, which both unconditionally sweepResolves SDK-92
Test plan
Paraswap_SellwithsellEntireBalance=trueincludes theerc20Transfersweep action🤖 Generated with Claude Code