fix(bundler): hardcode skipRevert: false on cleanup calls#520
Closed
fix(bundler): hardcode skipRevert: false on cleanup calls#520
Conversation
Cleanup calls (sweep-back transfers) in multi-call adapter sequences must never skip revert, as silent failure would strand tokens on permissionless adapters where anyone could steal them via erc20Transfer. Applies to erc20Wrapper wrap/unwrap and paraswap buy/sell/buyDebt flows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Superseeded by #518 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipRevert: false, preventing tokens from being stranded on permissionless adapters whenskipRevert=trueis set by the integratorwrap/unwrapand Paraswapbuy/sell/buyDebtflowsResolves SDK-93
Test plan
pnpm buildin bundler-sdk-viem)🤖 Generated with Claude Code