Skip to content

Types#48

Open
robertsLando wants to merge 1 commit into
mainfrom
types
Open

Types#48
robertsLando wants to merge 1 commit into
mainfrom
types

Conversation

@robertsLando

Copy link
Copy Markdown
Member

No description provided.

@robertsLando robertsLando requested a review from gnought February 24, 2020 10:12
@robertsLando

Copy link
Copy Markdown
Member Author

Tests will be fixed after merging #47

@mcollina mcollina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests for the types

@gnought

gnought commented Feb 24, 2020

Copy link
Copy Markdown
Collaborator

Hold a bit, I’m also working on it.
I’ll update some changes in this PR branch

@robertsLando

Copy link
Copy Markdown
Member Author

@gnought Ok I leave this to you so :)

@robertsLando

Copy link
Copy Markdown
Member Author

@gnought Could you replace this .on with .once ? https://github.com/moscajs/aedes-persistence/blob/master/abstract.js#L42

@robertsLando

Copy link
Copy Markdown
Member Author

@gnought ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants