README cleanup, tutorial directory #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a directory containing the previous examples. Created a blank template including all the OpenMM definitions. Users can remove/add to these as they please Need to add more about SMARTS however.
|
Should we include a readme in the tutorial section for SMARTS? Most of that is being covered in foyer's readmes. Unsure what would be necessary for the documentation besides that. |
|
Any updates on this? Looks like you've re-arranged it to be template + tutorial as we talked about. What's left to do from your perspective? Also one suggestion: adding links to the relevant openmm XML docs for each entry could be convenient. |
|
Just finishing the markdown document now. i went through and have some graphics to show the process to test the examples and what the expected output should be. Putting that together now. |
Revamped tutorial directory, blank template for user to work through. Included minimal walk through for tutorial. Images need work in tutorial, best I could do with my current resources. Passing forcefield template in top directory. Relative links where possible in the README's Image directory for including in tutorial, not all used.
removed superflous images
ctk3b
requested changes
May 22, 2017
| emulator of choice within this directory. | ||
| ```bash | ||
| py.test -v test_atomtyping.py --tb=line | ||
| ``` |
| def="H[C;X4]" | ||
| ``` | ||
| An important distinction should be pointed out here. In a `SMARTS` | ||
| definition, the first atom in the string is the atom of interest. |
There was a problem hiding this comment.
BOLD AND TRIPLE DOUBLE UNDERLINED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a directory containing the previous examples.
Created a blank template including all the OpenMM definitions.
Users can remove/add to these as they please
Need to add more about SMARTS however.