Fix new SonarQube code smells (S3024, S112, S1155) in service layer

[chetankh239]

Use StringBuilder.append chaining instead of string-concat append calls, narrow a generic Exception throw to the actual IOException, and use isEmpty() instead of size() comparisons.

Summary by CodeRabbit

• Refactor
  • Improved internal code readability and maintainability.
  • Clarified error handling and simplified empty-list checks.
  • No user-visible behavior or generated content has changed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f0665c35-d924-4b0e-bf37-3c9005bafd38

📥 Commits

Reviewing files that changed from the base of the PR and between 3d77f0a and 77b4b8b.

📒 Files selected for processing (3)

• mosip-compliance-toolkit/src/main/java/io/mosip/compliance/toolkit/service/BiometricTestDataService.java
• mosip-compliance-toolkit/src/main/java/io/mosip/compliance/toolkit/service/ReportService.java
• mosip-compliance-toolkit/src/main/java/io/mosip/compliance/toolkit/service/SbiProjectService.java

---

Walkthrough

The change updates three service methods. It replaces equivalent string concatenation and collection-size checks with standard APIs. It also narrows getPartnerDetails to declare IOException.

Changes

Service implementation cleanup

Layer / File(s)	Summary
Service method cleanup mosip-compliance-toolkit/src/main/java/io/mosip/compliance/toolkit/service/BiometricTestDataService.java, mosip-compliance-toolkit/src/main/java/io/mosip/compliance/toolkit/service/ReportService.java, mosip-compliance-toolkit/src/main/java/io/mosip/compliance/toolkit/service/SbiProjectService.java	prepareReadme uses chained StringBuilder.append calls. getPartnerDetails declares IOException and uses isEmpty(). The encryption-key error check uses !isEmpty().

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

Builders append words in line,
Empty checks now state the sign.
Exceptions narrow, clear, and bright,
Three small services read just right.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the service-layer changes that address SonarQube code smells S3024, S112, and S1155.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}