Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent stop or pause when drag constraints #2758

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: prevent stop or pause when drag constraints #2758

wants to merge 5 commits into from
+31 −7

Conversation

hyesungoh
Copy link

fix #2697

Hello there!

I appreciat your great works 👍

BTW I found some issue at above

as is

2024-08-10.4.11.08.mov

Element pause or stop when click it while dragging

https://github.com/framer/motion/blob/f59114d4d48f4fbd6a611aba62cd9ebab13e06ab/packages/framer-motion/src/gestures/drag/VisualElementDragControls.ts#L101-L103

I think it was problem

to be

2024-08-10.4.13.46.mov

So I prevent stop or pause animation when having dragConstraints

            // Stop or pause any animations on both axis values immediately when not using dragConstraints.
            // This allows the user to throw and catch the component.
            if (!dragConstraints) {
                dragSnapToOrigin ? this.pauseAnimation() : this.stopAnimation()
            }

If you think of any related issues, please share them with me!

Thank you! 😄

@injae-kim injae-kim mentioned this pull request Aug 10, 2024
Open
hyesungoh
hyesungoh commented Aug 11, 2024
View reviewed changes
packages/framer-motion/cypress/integration/drag.ts
Comment on lines +231 to +251
it("reset drag constraints (ref-based), when click after dragging", () => {
cy.visit("?test=drag-ref-constraints&elastic=1")
.wait(200)
.get("[data-testid='draggable']")
.trigger("pointerdown", 10, 10)
.wait(200)
.trigger("pointermove", 300, 300, { force: true })
.wait(200)
.trigger("pointerup", { force: true })
.trigger("pointerdown", { force: true })
.trigger("pointerup", { force: true })
.wait(1000)
.should(($draggable: any) => {
const draggable = $draggable[0] as HTMLDivElement
const { left, top } = draggable.getBoundingClientRect()

expect(left).to.equal(150)
expect(top).to.equal(150)
})
})

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I append E2E test for issue #2697

I'm wondering if it's appropriate to set wait for 1000ms 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Drag-Element gets stuck when clicked while animating
1 participant
@hyesungoh