Skip to content

Conversation

abhinav0git
Copy link

@abhinav0git abhinav0git commented Oct 18, 2025

Changes

  1. HTTP Method Selector Placement

    • Moved HTTP method dropdown above URL bar so now the url bar gets a bit more space to render the url
    • Removed from inside URL input field
  2. Build Process Enhancement

    • Added Rust toolchain initialization check before WASM build
    • Prevents build failures in environments without Rust pre-installed (eg: cargo: command not found, rustc: command not found)
  3. Dependency Version Update

    • Bumped @yaakapp/api to v0.7.0 in plugin-runtime-types

(p.s. great tool btw, I absolutely loved it. Any feedback is welcomed 😊)
.
.
edit: i was facing major issues while setting up the project on my mac, was getting "cargo: command not found" so i have added this extra tool initialisation in the build command

Abhinav Singh and others added 3 commits October 18, 2025 22:09
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR introduces three main changes to the Yaak desktop API client: a UI layout adjustment, a build process modification, and a dependency update. The HTTP method dropdown has been relocated from inside the URL input field to a position above it, giving the URL bar full horizontal width for better visibility of long URLs. This is achieved by restructuring the HttpRequestPane component to use a vertical flex layout with separate containers for the method selector and URL bar. The build configuration in the WASM templates package attempts to initialize the Rust toolchain by sourcing the cargo environment file before running wasm-pack. Additionally, the plugin-runtime-types package has had its @yaakapp/api dependency updated. These changes integrate into the existing request pane rendering logic and build toolchain without modifying the underlying HTTP request handling or plugin runtime behavior.

Changed Files
Filename Score Overview
src-tauri/yaak-templates/package.json 2/5 Added shell command to source Rust cargo environment before WASM build, introducing cross-platform compatibility concerns
src-web/components/HttpRequestPane.tsx 4/5 Restructured layout to move HTTP method dropdown above URL bar instead of inside it, giving URL input more horizontal space

Confidence score: 2/5

  • This PR contains a critical cross-platform compatibility issue that will cause build failures on Windows systems and may behave unpredictably in certain environments
  • Score primarily lowered due to the Rust environment sourcing approach in package.json being Unix-specific (. $HOME/.cargo/env) which breaks on Windows and doesn't properly validate Rust availability; additionally, sourcing may silently fail in some shells if the file doesn't exist
  • src-tauri/yaak-templates/package.json requires immediate attention and should use a cross-platform solution (e.g., check for cargo in PATH, use a Node.js script, or document prerequisites); there's also a minor style inconsistency in HttpRequestPane.tsx at line 362 with single quotes vs double quotes

Additional Comments (2)

  1. src-tauri/yaak-templates/package.json, line 8 (link)

    logic: Sourcing $HOME/.cargo/env will fail on Windows (no . command in cmd/powershell) and won't work in CI environments where Rust is installed system-wide rather than via rustup. Consider checking for cargo availability using a cross-platform approach or documenting that Rust must be in PATH. Will this build script run on Windows or in CI environments where Rust isn't installed via rustup in $HOME/.cargo?

  2. src-tauri/yaak-templates/package.json, line 8 (link)

    logic: The && will cause the build to silently succeed even if sourcing fails (. $HOME/.cargo/env returns 0 when the file doesn't exist in some shells). This masks missing Rust installations instead of failing fast.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@gschier
Copy link
Member

gschier commented Oct 19, 2025

Thanks for the PR! However, I'm going to have to close it due to the following reasons:

  • I don't think the method above the URL bar fits the design well (screenshot for reference)
  • Build command change is not cross-platform compatible and seems specific to your environment
CleanShot 2025-10-19 at 11 36 21@2x

@gschier gschier closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants