Skip to content

fix(google-tasks): couple showHidden with show_completed#159

Merged
peteski22 merged 1 commit into
mainfrom
fix/google-tasks-show-hidden-completed
Jul 3, 2026
Merged

fix(google-tasks): couple showHidden with show_completed#159
peteski22 merged 1 commit into
mainfrom
fix/google-tasks-show-hidden-completed

Conversation

@peteski22

Copy link
Copy Markdown
Contributor

Summary

google_tasks_list_tasks accepted show_completed=true but returned no completed tasks. The Google Tasks API marks completed items as hidden, and the tool hardcoded showHidden="false", so completed tasks were filtered back out — making the parameter a no-op.

Fix

Couple showHidden with show_completed: send showHidden="true" when show_completed=true, and "false" otherwise, so opted-in completed (hidden) tasks are returned.

Tests

Extended the two existing behavioral tests to assert showHidden moves in lockstep with showCompleted:

  • test_hides_completed_by_default → request carries showHidden=false
  • test_show_completed_opt_in → request carries showHidden=true

Wrote the failing assertions first, confirmed they failed for the right reason, then applied the fix.

Verification

  • uv run pytest tests/providers/google/tasks/ → 59 passed
  • pre-commit (ruff, ruff-format, detect-secrets) passed on touched files

Note

The ty type-check hook currently fails on a pre-existing, unrelated error in src/apron_tools/providers/salesforce/tools.py:376 (search_records unknown argument), reproducible on main untouched. Not caused by this change; worth a separate look (possibly a ty version behavior change, since make lint runs on PRs and hasn't been flagging it).

Fixes #147

The Tasks API marks completed items as hidden, so hardcoding
showHidden=false filtered completed tasks back out even when callers
passed show_completed=true, making the parameter a no-op.

Send showHidden=true whenever show_completed is true (and false
otherwise) so opted-in completed tasks are returned.

Fixes #147
@peteski22 peteski22 force-pushed the fix/google-tasks-show-hidden-completed branch from 3ea7ee5 to 2c8b853 Compare July 3, 2026 13:05
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@peteski22, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1168cb66-d557-46d1-86d5-554e175a59c1

📥 Commits

Reviewing files that changed from the base of the PR and between 884a794 and 2c8b853.

📒 Files selected for processing (2)
  • src/apron_tools/providers/google/tasks/tools.py
  • tests/providers/google/tasks/test_tools.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/google-tasks-show-hidden-completed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@peteski22 peteski22 merged commit 98b4a62 into main Jul 3, 2026
8 checks passed
@peteski22 peteski22 deleted the fix/google-tasks-show-hidden-completed branch July 3, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_tasks_list_tasks returns no completed tasks (couple showHidden with showCompleted)

1 participant