feat(slack): add channel file upload tool#165
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new Slack tool, ChangesSlack channel file upload tool
Related issues: Closes Suggested labels: review_needed_junior_swe, review_depth_deep Suggested reviewers: (none specified) 🐰 A file hops into Slack with glee, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/providers/slack/test_tools.py`:
- Around line 441-548: Add test coverage for the `resolve_file_input` error
branches in `TestSlackSendChannelMessageWithFile`: mock
`apron_tools.providers.slack.tools.resolve_file_input` to raise
`httpx.HTTPStatusError` and `httpx.HTTPError`, then assert
`slack_send_channel_message_with_file` returns a domain error instead of
propagating the exception. Reuse the existing
`test_file_from_url_is_resolved_before_upload` setup and the
`slack_send_channel_message_with_file` / `resolve_file_input` symbols to keep
the new cases close to the current URL-resolution test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: dae7ee3e-0291-46af-9b59-bf155e97733b
📒 Files selected for processing (5)
src/apron_tools/providers/slack/scopes.pysrc/apron_tools/providers/slack/tools.pysrc/apron_tools/providers/slack/types.pytests/providers/slack/test_tools.pytests/providers/slack/test_types.py
What
Why
Implements #153 by providing a first-class Slack channel file upload tool that composes with FileInput producers and uses the current v2 upload flow.
Validation
Closes #153
Summary by CodeRabbit
New Features
Bug Fixes