docs(cli): document Homebrew tap trust for third-party tap installs#483
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a note to ChangesHomebrew Installation Docs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/README.md`:
- Line 26: The Homebrew version timeline wording in the trust note is ambiguous
and should be clarified in the README text around the `mozilla-ai/tap/cq`
installation guidance. Update the sentence so it does not imply a conflicting
“whichever comes first” version expectation; either remove the speculative
release numbers entirely or rephrase them as an uncertain future release
example, keeping the guidance about `tap trust` and fully-qualified cask
installs intact.
- Around line 26-33: The Homebrew trust guidance in the README needs a minimum
version note because brew trust may not exist on older installs. Update the
Homebrew tap trust section in cli/README.md to mention the minimum Homebrew
version or supported release needed for brew trust, and if applicable add a
fallback path for users on older Homebrew versions. Keep the guidance aligned
with the existing brew tap, brew trust --cask, and brew install --cask cq
instructions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Homebrew will require explicit trust for non-official taps in a future release (6.0.0 or 5.2.0, whichever comes first). The existing 'brew install --cask mozilla-ai/tap/cq' is fully-qualified and already trusts only that cask, so it keeps working; this note makes that explicit and documents 'brew trust --cask' for users who tap first and install by short name.
peteski22
force-pushed
the
docs/brew-tap-trust
branch
from
12ad86d to
e4bc7be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a tap-trust note to
cli/README.md(the canonical install doc referenced byREADME.mdandDEVELOPMENT.md).Why
Homebrew is moving to require explicit trust for non-official (third-party) taps — warnings now via
brew doctorand install commands, enforced by default in Homebrew 6.0.0 or 5.2.0, whichever comes first. See docs.brew.sh/Tap-Trust.Our documented command
brew install --cask mozilla-ai/tap/cqis already fully-qualified, which trusts only thecqcask, so it keeps working untouched under tap trust. The note makes that explicit and documents thebrew trust --caskpath for users whobrew tapfirst and install by short name.cqships as a cask, so the short-name path uses--cask(not--formula).No command was changed — this is documentation only.
Verification
Summary by CodeRabbit