Skip to content

Pin Node.js version to 22.10.0+ in CI workflows - #9

Merged
peteski22 merged 1 commit into
mainfrom
pin-node-version
Nov 18, 2025
Merged

Pin Node.js version to 22.10.0+ in CI workflows#9
peteski22 merged 1 commit into
mainfrom
pin-node-version

Conversation

@peteski22

@peteski22 peteski22 commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Pin Node.js version from '22' to >=22.10.0 in all GitHub Actions workflows to explicitly match the minimum version required by npm@11.6.2 and our package.json engines constraint.

Refs: #8

Summary by CodeRabbit

  • Chores
    • Updated Node.js minimum version requirement from 22.9.0 to 22.10.0
    • Updated build and test workflows to accept any Node.js 22.x minor version
    • Updated project documentation with new Node.js prerequisites and recommendations

@peteski22
peteski22 force-pushed the pin-node-version branch 2 times, most recently from 604b74a to e43f0fa Compare November 18, 2025 12:18
@peteski22 peteski22 changed the title Pin Node.js version to 22.9.0 in CI workflows Pin Node.js version to 22.10.0+ in CI workflows Nov 18, 2025
- Changed CI workflows to use node-version '22.x' (latest 22.x)
- Updated engines.node requirement from >=22.9.0 to >=22.10.0
- Updated README to reflect Node 22.10.0+ requirement
- Node 22.9.0 has ESM compatibility issues with vitest; 22.10+ fixes these
@mozilla-ai mozilla-ai deleted a comment from coderabbitai Bot Nov 18, 2025
@mozilla-ai mozilla-ai deleted a comment from coderabbitai Bot Nov 18, 2025
@peteski22
peteski22 requested a review from agpituk November 18, 2025 12:21
@peteski22
peteski22 merged commit 0ccc82f into main Nov 18, 2025
2 of 3 checks passed
@peteski22
peteski22 deleted the pin-node-version branch November 18, 2025 12:23
@coderabbitai

coderabbitai Bot commented Nov 18, 2025

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{"name":"HttpError","status":404,"request":{"method":"PATCH","url":"https://api.github.com/repos/mozilla-ai/mcpd-proxy/issues/comments/3547333671","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: failure by coderabbit.ai -->\n\n> [!CAUTION]\n> ## Review failed\n> \n> The pull request is closed.\n\n<!-- end of auto-generated comment: failure by coderabbit.ai -->\n\n<!-- walkthrough_start -->\n\n## Walkthrough\n\nNode.js version requirements updated across configuration files. Workflow files modified to use '22.x' version specifier. README and package.json engine requirement bumped from 22.9.0+ to 22.10.0+.\n\n## Changes\n\n| Cohort / File(s) | Summary |\n|---|---|\n| **GitHub Actions workflows (Node.js specifier)** <br> `.github/workflows/lint.yaml`, `.github/workflows/release.yaml`, `.github/workflows/tests.yaml` | Updated Node.js setup step from `node-version: '22'` to `node-version: '22.x'` for more flexible minor version resolution |\n| **Configuration and documentation (engine requirement)** <br> `package.json`, `README.md` | Bumped Node.js engine requirement from 22.9.0+ to 22.10.0+; README also includes recommendation for latest 22.x series |\n\n<!-- walkthrough_end -->\n\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing touches</summary>\n\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"07f1e7d6-8a8e-4e23-9900-8731c2c87f58\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Post copyable unit tests in a comment\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Commit unit tests in branch `pin-node-version`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n\n\n---\n\n<details>\n<summary>📜 Recent review details</summary>\n\n**Configuration used**: CodeRabbit UI\n\n**Review profile**: ASSERTIVE\n\n**Plan**: Pro\n\n<details>\n<summary>📥 Commits</summary>\n\nReviewing files that changed from the base of the PR and between d9a2a3ea6ff3a4eed71bcb2155bbfa2c9931a1ed and 9440cfe4bea7852b590b7933cb3ec732b63f6f81.\n\n</details>\n\n<details>\n<summary>⛔ Files ignored due to path filters (1)</summary>\n\n* `package-lock.json` is excluded by `!**/package-lock.json`\n\n</details>\n\n<details>\n<summary>📒 Files selected for processing (5)</summary>\n\n* `.github/workflows/lint.yaml` (1 hunks)\n* `.github/workflows/release.yaml` (1 hunks)\n* `.github/workflows/tests.yaml` (1 hunks)\n* `README.md` (1 hunks)\n* `package.json` (1 hunks)\n\n</details>\n\n</details>\n\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=mozilla-ai/mcpd-proxy&utm_content=9)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n\n<!-- internal state start -->\n\n\n<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKPR1AGxJcr8LADlFEg0hZCkKRHh8LAJIACY4jQBGAAYNFIBqFCwAYQBJSAB3fAoAawAzD3xCxDcEZG5sDw9IChIAR2xpXEhsblpqaXRmyABxdQAJbAFIAEExKIxkYrLK6uRYhlhMUkhcWBJIQKUQsMpI6PtuUXhy+AZqRchyihZIACIE9738D70AXgSyTSKXeGhgB0Y2wwu1QfhoGCU9FiJAAHtwPPdPPJmNQtntIcw/PBmI4jkFTpBwhcsG1OvA2vQ5JAMNxmAABJJJDQANg0cXQiIJh14+BEYgA5A00AxSmhSKdLmQiH4hkwlrgqPDwXBDrZWiRypQyAwhmgeBQonw2h5BvR9QAKZj4ABe8GaaDA2gA9MwGP0wKLUbIzAAOACUGiM+mM4CgZHo+HKOAIxDIyho9CYrHYXF4/GEonEUhk8iYSioqnUWh0MZMUDgcOQmBThFI5ComYUOYwnFaaEK9kcuJckGZ5eUVc02l0YEMsdMBg0Kv2029KwqVRq3sxvY0sjQzA8HAM7zPBgsczyaY7dqHTlHSahO2kRhy0NIyMhx2CoXsJFwPp7Bobgfl6RBDnNZ02h4SgiUQSIpCpc4nkQa4GFueBKHBGwSAxGU6BZIIwGpRYuAlBIJSKdRYCIpQSJQ6JyKBVEqNiNBmmqQV5BYyAiQwEpkIiRYoyMC9LFmDwaE7RYNl+fZDiUBhbRk6JkCfNFuBKLtBMaARMQYSB2HULDagMQJyHMSwAFlMFubpIAAMXdQ5ZgwDjZBdSgjAAUUQcRcS7CcDQkLDB0NcptK4ay6HgRxT3PAwIDAIxlxotcNzWbcbRINAIP3Q9jwS95xKvG8M0IhwH3kJ8thfMyoDyLA0tXAR1xKTd1m9HK8uCA8jwAGmFSAAGUAKAn9KX8vDnxhQiFLokgGOEy4XjeCi4jY34No0VjwUCfgFL4Oq5rk4C8PU47ok1fAWiy0SrLmKSM1ksCFqUlTHjU/hk007TCN06YDKM3sTNfJLIAdATyHDXz/JJO9graUKSHC8pIooPsYtoOLmGK6NFxa2AMo6rLEG9Gh/MQAqjxPM8SsvWZr3bCr6CqkcauTE7SAayAmuG8ZcCmGZ5nEb7Mq3IaFoE+jSMuPxhrGwDQMmv9ptAwo8tmz9nleZhIA2raDZYiUhr8HGHnEGF0D4kpDkqNF4H0w5+MEuXaWkW68BEsTSsk6SvqWN7IQ+5xA/U370X+xM+D04HjPEcGoAskg4YCxGghCsKjPRqLIGx3H8aSxcbB82YABFrJ8jRmFoOnz0Z5n007Srh2cTntaTyAACFHGuehVYaNo6WwJB1HtvX4kSABOdIsliIFUjnqMoFmWgkSImgDWzNhET8IhhttSmel4iDLWkB6/ee1Sg9id7RE+sWg40qPMYB2OgfuEHxET3mDu5oYKJX46Q/vpL+Cd5ChxvtTNOCMgqZ2RtnCKecC7xXpgTFKBhuAyjlAqUITF8aN3Ki3NmbdHxcw/ODAA8hgDw8gFqDxBiqcgBp6RtF3j0TWyA+gDEzFwd4MsSDfAVsqVUyAAH0DWvrAEQJZ4pDAjIxIS80jkkOgcPg5RsAYAWNEDi/A+D+QoNgMQ2AqAtAAepAQZ8pC0EvsnX4FiwJ/TfrQb0ccv5QPDqJPy6d4FKCzqjHOGMsaxTQYlGMBh6wg0TMmNAeA2zNwzj2PsVBBzs3bmOMsQRKxqGnLWOcQA= -->\n\n<!-- internal state end -->"},"request":{"retryCount":1}},"response":{"url":"https://api.github.com/repos/mozilla-ai/mcpd-proxy/issues/comments/3547333671","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Tue, 18 Nov 2025 12:24:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"github.com","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-accepted-github-permissions":"issues=write; pull_requests=write","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-api-version-selected":"2022-11-28","x-github-media-type":"github.v3; format=json","x-github-request-id":"506B:13625:4A57E36:14F02B20:691C6571","x-ratelimit-limit":"5050","x-ratelimit-remaining":"5000","x-ratelimit-reset":"1763471993","x-ratelimit-resource":"core","x-ratelimit-used":"50","x-xss-protection":"0"},"data":{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#update-an-issue-comment","status":"404"}}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants