ci: trigger crates.io publish on GitHub Release instead of tag push#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v*) to GitHub Release publish eventgithub-releasejob (no longer needed since the release already exists when the workflow runs)github.event.release.tag_nameinstead ofGITHUB_REFMotivation
Publishing to crates.io should be triggered by creating a GitHub Release, not by pushing a tag directly. This makes the release the single source of truth and gives better control over the publish process (e.g., draft releases won't trigger a publish).
Release workflow after this change
Cargo.tomland merge tomaingh release create v0.1.0)Prerequisites for first publish
The
CARGO_REGISTRY_TOKENsecret must be configured in the repository settings with a valid crates.io API token.