automation_worker: update pull request with backout information (Bug 2024925)#1325
Open
Magnolia-Liu wants to merge 30 commits into
Open
automation_worker: update pull request with backout information (Bug 2024925)#1325Magnolia-Liu wants to merge 30 commits into
Magnolia-Liu wants to merge 30 commits into
Conversation
|
View this pull request in Lando to land it once approved. |
Magnolia-Liu
marked this pull request as ready for review
July 10, 2026 17:28
shtrom
requested changes
Jul 13, 2026
shtrom
left a comment
shtrom
left a comment
Member
There was a problem hiding this comment.
The logic looks good, but most of the utility functions should go to main.scm or utils.github, where they would be more easily found, reused, and maintained. This may also help reduce some duplication introduced here.
Magnolia-Liu
force-pushed
the
magnolia/bug-2024925-updating-pr-with-backout-info
branch
from
July 14, 2026 15:30
98d0895 to
3de078e
Compare
shtrom
requested changes
Jul 20, 2026
shtrom
left a comment
shtrom
left a comment
Member
There was a problem hiding this comment.
Mainly comments on good practices and making the code reusable and debuggable in prod.
This is looking good, though (:
…t commits return commit data list instead of string list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Phabricator, when a revision is backed out, it is updated with the commits and is reopened so it's clear the change was reverted.
Implement something similar: The AutomationWorker now detects reverts among the commits it lands and comments on the affected pull requests.
This is comment-only for now. Reopening the reverted pull request can be implemented in a follow-up bug.
Lando: link
Bugzilla: bug 2024925
🚫 This pull request has 1 blocker.