Bug XXXXXXX - Report whether the account holds the Sync keys over the web-channel - #338
Closed
dschom wants to merge 2 commits into
Closed
Bug XXXXXXX - Report whether the account holds the Sync keys over the web-channel#338dschom wants to merge 2 commits into
dschom wants to merge 2 commits into
Conversation
Adds the fxaccounts:pair_oauth_start and fxaccounts:pair_oauth_finish web-channel commands, gated on a new identity.fxaccounts.pairing.version pref that is advertised to FxA as capabilities.pairingVersion. Acting as the supplicant, pair_oauth_start begins an OAuth flow and hands FxA only the public parameters (state, scope, code_challenge, keys_jwk), so the code verifier never leaves the browser. Acting as the authority, pair_oauth_finish grants an authorization code for a supplicant's parameters. _authorizeOAuthCode and the keys_jwe construction move out of FxAccountsPairing and into FxAccountsOAuth, so the channel-server pairing flow and the new web-channel command share one implementation. On Android, FxaCapability.PAIRING_V2 advertises pairingVersion and enables fxaccounts:pair_oauth_start.
… web-channel Adds capabilities.hasSyncKeys to the fxaccounts:fxa_status web-channel response, so FxA can tell whether the signed-in account has been granted the Sync scope and therefore holds the Sync key. On Desktop this is false when nobody is signed in and also when a locked Primary Password stops us reading the keys. Supporting this on Android needs a way to ask an account which scopes it has been granted, so OAuthAccount grows a hasScope method. That is a breaking change for concept-sync consumers: hasScope is abstract, so every implementor must override it. A default would be worse, since an implementor that forgot to override it would silently report that it holds no Sync keys rather than failing to build.
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
dschom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.