Bug 2062477 pairing v2 - #344
Closed
dschom wants to merge 2 commits into
Closed
Conversation
…h,roger Adds the fxaccounts:pair_oauth_start and fxaccounts:pair_oauth_finish web-channel commands, gated on a new identity.fxaccounts.pairing.version pref that is advertised to FxA as capabilities.pairingVersion. Acting as the supplicant, the pair_oauth_start command begins an OAuth flow and responds with the parameters: state, scope, code_challenge, and keys_jwk. Note the code verifier never leaves the browser, and that these parameters were all previously exposed on the /pair/supp/allow url. Acting as the authority, the pair_oauth_finish command grants an authorization code for a supplicant's parameters. The _authorizeOAuthCode and the createKeysJWE methods move out of FxAccountsPairing and into FxAccountsOAuth, so the channel-server pairing flow and the new web-channel command can share one implementation. It’s also worth noting that these methods represent operations that are part of the oauth process and therefore are a better fit for the FxAccountsOAuth module anyways. On Android, FxaCapability.PAIRING_V2 advertises pairingVersion and enables fxaccounts:pair_oauth_start, and the fxaccounts:pair_oauth_start has been wired up. Differential Revision: https://phabricator.services.mozilla.com/D319867
No Taskcluster jobs started for this pull requestThe |
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking to the actual changset used in phabricator