Bug 2065660 - Remove redundant atomization in attribute selector parsing. r=#style - #347
Closed
emilio wants to merge 1 commit into
Closed
Bug 2065660 - Remove redundant atomization in attribute selector parsing. r=#style#347emilio wants to merge 1 commit into
emilio wants to merge 1 commit into
Conversation
…ing. r=#style If the name is lowercase there's no need to atomize twice.
Contributor
|
View this pull request in Lando to land it once approved. |
dshin-moz
reviewed
Aug 21, 2026
| @@ -3165,7 +3165,7 @@ where | |||
|
|
|||
| let attribute_flags = parse_attribute_flags(input)?; | |||
| let value = value.as_ref().into(); | |||
| let local_name_lower; | |||
| let local_name_lower: Impl::LocalName; | |||
| let local_name_is_ascii_lowercase; | |||
| let case_sensitivity; | |||
| { | |||
Contributor
There was a problem hiding this comment.
Nit: tuple assignment (Weak preference, maybe Impl::LocalName to avoid type deduction issues)?
Contributor
Author
There was a problem hiding this comment.
Yeah, but it gets a bit weird because some of the temporaries escape and some don't...
dshin-moz
approved these changes
Aug 21, 2026
lando-worker Bot
pushed a commit
that referenced
this pull request
Aug 22, 2026
…ing. r=dshin If the name is lowercase there's no need to atomize twice. Pull request: #347
|
Pull request closed by commit e6cdc04 |
github-actions Bot
pushed a commit
to DioxusLabs/stylo
that referenced
this pull request
Aug 23, 2026
…ing. r=dshin If the name is lowercase there's no need to atomize twice. Pull request: mozilla-firefox/firefox#347
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the name is lowercase there's no need to atomize twice.