Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nits for mordor #10017

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Nits for mordor #10017

wants to merge 3 commits into from

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Nov 6, 2024

  • Dont try to give a pointer to an unallocated vector
  • Dont try to create an address from an empty string
  • Use correct byteorder for wireguard

Description

Describe your changes

Reference

i.e Jira or Github issue URL

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@strseb strseb requested a review from oskirby November 6, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant