VPN-6796: Update Qt/Wasm to 6.6.3 #10233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskirby
force-pushed
the
vpn-6796-qt-wasm-update
branch
from
9308640 to
de5a026
Compare
oskirby
force-pushed
the
vpn-6796-qt-wasm-update
branch
2 times, most recently
from
c739a7e to
ce5c298
Compare
oskirby
force-pushed
the
vpn-6796-qt-wasm-update
branch
from
ce5c298 to
214eef3
Compare
oskirby
force-pushed
the
vpn-6796-qt-wasm-update
branch
from
2324046 to
c478db3
Compare
oskirby
changed the title
oskirby
requested review from
gabrielBusta,
mcleinman and
strseb
and removed request for
a team
strseb
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This attempts to update WASM's version of Qt to 6.6.3. This keeps it in sync with the rest of our target platforms, and fixes an issue in Thai font rendering that would lead to a crash.
This update wasn't quite as straightforward as we would like, since the WASM instantiation process has changed in Qt 6.5 to use a new API, which required a hefty change to the HTML pages.
Reference
JIRA Issue: VPN-6796
JIRA Issue: VPN-6795
Checklist