Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6783: detect system theme changes #10235

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

mcleinman
Copy link
Collaborator

@mcleinman mcleinman commented Jan 29, 2025

Description

Detect when the system theme changes. VPN-6178 will add the code that actually exposes this to the user.

This will not work on Qt version <6.5, to keep it in line with the prior system color work.

Reference

VPN-6783

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to merge an empty connect - as i doubt the compiler will optimize that away :)
maybe we can keep this open until we start VPN-6178?

@mcleinman
Copy link
Collaborator Author

mcleinman commented Jan 30, 2025

I would prefer not to merge an empty connect - as i doubt the compiler will optimize that away :) maybe we can keep this open until we start VPN-6178?

What if we keep this code in there, but fully comment it out for now?

@mcleinman mcleinman force-pushed the vpn-6783-detect-system-theme-change branch from 31231ab to 22cd9d1 Compare February 3, 2025 22:29
@mcleinman
Copy link
Collaborator Author

mcleinman commented Feb 3, 2025

I would prefer not to merge an empty connect - as i doubt the compiler will optimize that away :) maybe we can keep this open until we start VPN-6178?

What if we keep this code in there, but fully comment it out for now?

I commented it out w/ some notes about the future work here. Will merge this after tests pass.

@mcleinman mcleinman merged commit 92bd8ef into main Feb 3, 2025
120 checks passed
@mcleinman mcleinman deleted the vpn-6783-detect-system-theme-change branch February 3, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants