Skip to content

Add missing asterick for important fields in contact form - #11339

Open
Sukumarsawant wants to merge 3 commits into
mozilla-mobile:mainfrom
Sukumarsawant:asterick
Open

Add missing asterick for important fields in contact form#11339
Sukumarsawant wants to merge 3 commits into
mozilla-mobile:mainfrom
Sukumarsawant:asterick

Conversation

@Sukumarsawant

@Sukumarsawant Sukumarsawant commented Jun 4, 2026

Copy link
Copy Markdown

Description

Added red asterisk indicators (*) to all mandatory fields in the Contact Support form to clearly communicate to users which fields are required before submission.

Fields updated:

Email address & Confirm email

Reference

#5636

Checklist

  • My code follows the style guidelines for this project.
  • I have not added any packages that contain high-risk or unknown licenses (GPL, LGPL, MPL, etc.; consult DevOps if in question).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added thorough tests where needed.

@Sukumarsawant Sukumarsawant changed the title Asterick Add missing asterick for important fields in contact form Jun 4, 2026
@Sukumarsawant
Sukumarsawant marked this pull request as ready for review June 4, 2026 21:32
@Sukumarsawant

Sukumarsawant commented Jun 4, 2026

Copy link
Copy Markdown
Author

@strseb @mcleinman do have a look once and let me know if you there's anything more need in it . The fix looked simple to me yet stale for years now somehow?

Ekram-B2

This comment was marked as off-topic.

@strseb strseb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! First off, thank you very much for the PR!

Just a small change, then this is good to go. Visually this is fine but the current change will also change the text that the screen reader reads to something like depending on os+screenreader combo

“Enter your email star”
or
“Enter your email asterisk”

Which may be more confusing then helpful. Please add

Accessible.name: enterEmailAddress

so that the text for screen readers remains text-only :)

@Sukumarsawant

Sukumarsawant commented Aug 7, 2026

Copy link
Copy Markdown
Author

Hey! First off, thank you very much for the PR!

Just a small change, then this is good to go. Visually this is fine but the current change will also change the text that the screen reader reads to something like depending on os+screenreader combo

“Enter your email star”
or
“Enter your email asterisk”

Which may be more confusing then helpful. Please add

Accessible.name: enterEmailAddress

so that the text for screen readers remains text-only :)

hey sorry for the delay. GitHub somehow didn't ping me for this one. I am adding this change
Also, I never considered (missed) that the screen reader would read it that way; thanks !!

@Sukumarsawant
Sukumarsawant marked this pull request as draft August 7, 2026 20:51
@Sukumarsawant
Sukumarsawant marked this pull request as ready for review August 7, 2026 21:10
@Sukumarsawant

Copy link
Copy Markdown
Author

Have pushed the change @strseb, do tag me if there's anything wrong in this or anything I missed
Also, is there any way I could test the CI (any commands or so )?
Or would it be required to run manually?

@Sukumarsawant
Sukumarsawant requested a review from strseb August 8, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants