chore(auth): remove dead code related to /certificate/sign#20207
Open
chore(auth): remove dead code related to /certificate/sign#20207
Conversation
vbudhram
approved these changes
Mar 18, 2026
LZoog
reviewed
Mar 18, 2026
| // For desktop, the 'service' parameter for this event gets | ||
| // special-cased to 'sync' so that it matches its pre-oauth | ||
| // `/certificate/sign` event. | ||
| // special-cased to 'sync' for historical continuity with the pre-oauth flow. |
Contributor
There was a problem hiding this comment.
Is this still true? Or maybe we need added context here? It's almost more confusing to me not to leave the certificate/sign comment there since historically that is what we were trying to match parity with (I think).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13290