[DENG-7616] Pipeline to send events to Amplitude #2729
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2729 +/- ##
============================================
- Coverage 85.98% 84.71% -1.27%
- Complexity 876 935 +59
============================================
Files 118 125 +7
Lines 4994 5319 +325
Branches 504 535 +31
============================================
+ Hits 4294 4506 +212
- Misses 539 637 +98
- Partials 161 176 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
scholtzan
force-pushed
the
events-to-amplitude
branch
from
21114dc to
97d4d72
Compare
scholtzan
force-pushed
the
events-to-amplitude
branch
from
97d4d72 to
7709509
Compare
scholtzan
force-pushed
the
events-to-amplitude
branch
from
3a174af to
a438de9
Compare
scholtzan
force-pushed
the
events-to-amplitude
branch
2 times, most recently
from
6e1c08d to
90ce8a6
Compare
scholtzan
force-pushed
the
events-to-amplitude
branch
from
90ce8a6 to
0ee9993
Compare
scholtzan
force-pushed
the
events-to-amplitude
branch
from
b8984d3 to
0ff5016
Compare
scholtzan
commented
Feb 20, 2025
Comment on lines
59
to
83
| if (getEventExtras() == null || getEventExtras().equals("null")) { | ||
| eventExtras.put("extras", (ObjectNode) new ObjectMapper().readTree("{}")); | ||
| } else { | ||
| eventExtras.put("extras", (ObjectNode) new ObjectMapper().readTree(getEventExtras())); | ||
| } | ||
|
|
||
| json.put("event_properties", eventExtras); | ||
| json.put("event_type", getEventType()); | ||
| json.put("platform", getPlatform()); | ||
|
|
||
| if (getAppVersion() != null && !getAppVersion().equals("null")) { | ||
| json.put("app_version", getAppVersion()); | ||
| } | ||
|
|
||
| if (getOsName() != null && !getOsName().equals("null")) { | ||
| json.put("os_name", getOsName()); | ||
| } | ||
|
|
||
| if (getOsVersion() != null && !getOsVersion().equals("null")) { | ||
| json.put("os_version", getOsVersion()); | ||
| } | ||
|
|
||
| if (getCountry() != null && !getCountry().equals("null")) { | ||
| json.put("country", getCountry()); | ||
| } |
There was a problem hiding this comment.
these are the attributed currently sent to amplitude
scholtzan
force-pushed
the
events-to-amplitude
branch
from
0ff5016 to
ede18c9
Compare
scholtzan
force-pushed
the
events-to-amplitude
branch
from
ede18c9 to
f6ff723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mozilla-hub.atlassian.net/browse/DENG-7616