Allow comment authors to edit and delete their own comments#4024
Allow comment authors to edit and delete their own comments#4024mathjazz merged 7 commits intomozilla:mainfrom
Conversation
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
Allow comment authors to edit and delete their own comments This commit Adds edit and delete comment views, corresponding URLs, changes the comment component and adds tests for both views and component changes
9bc8ae9 to
e0066eb
Compare
mathjazz
left a comment
There was a problem hiding this comment.
Great work!
The feature works fine and the code looks good on the surface.
My only complaint is that the alignment of the comment editor in Translation History panel and the alignment of buttons underneath it, is off:
BTW, this feature will also need docs update (just added a label to the issue):
https://mozilla-l10n.github.io/localizer-documentation/tools/pontoon/glossary.html#comment
|
Thanks for the update! In translation comments, the editor (and the avatar) are still indented right. |
The info row uses margin top -2px to be close to the comment bubble In edit mode, this adds 14px of extra height pushing the info section row down. Compensate with margin-top: -16px on .is-editing .info.
mathjazz
left a comment
There was a problem hiding this comment.
@MundiaNderi Sorry for the tedious review process. Found a few more smaller things.
One other thing I noticed is that when you hover the Cancel, Delete and Edit buttons, the middot separating the buttons also changes color. It shouldn't.
Also, we could use var(--status-error) when hovering the Delete button.
mathjazz
left a comment
There was a problem hiding this comment.
Great work, thanks for keeping up with the tedious review process! :)
Actually none of the existig docs get outdated by merging this change. As a bonus, we can still document the ability to edit and delete comments, but a blog post would be even better. |


Fixes #2383
This PR
Adds edit and delete comment views, corresponding URLs, changes the comment components and adds tests for both views and component changes
To test/how I tested: