fix: add comma flag to printf regex to correctly highlight placeholder#4049
Merged
mathjazz merged 1 commit intomozilla:mainfrom Mar 31, 2026
Merged
Conversation
mathjazz
approved these changes
Mar 31, 2026
Collaborator
mathjazz
left a comment
mathjazz
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The printf placeholder regex in Pontoon's translation editor did not include the , (comma) flag in its format specifier pattern. This caused placeholders like %2$,d, a valid Java/Android printf format that renders integers with thousands separators (e.g. 1,000), to go un-highlighted in the translate view, making them invisible to translators who need to preserve them in their translations.
The fix adds , to the flags character class in the printf regex in both placeholder.ts (used for highlighting) and editFieldModes.ts (used for editor syntax),bringing them in sync and ensuring %2$,d is correctly identified and highlighted alongside other placeholders.
Closes
Fixes #4039
Screenshots