make sccache -s always return current cache size #2419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
force-pushed
the
always_show_cache
branch
from
4740041 to
9ded41b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2419 +/- ##
=======================================
Coverage 71.58% 71.58%
=======================================
Files 65 66 +1
Lines 36372 36384 +12
=======================================
+ Hits 26037 26047 +10
- Misses 10335 10337 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sylvestre
force-pushed
the
always_show_cache
branch
from
d0894e8 to
340c5d6
Compare
sylvestre
force-pushed
the
always_show_cache
branch
2 times, most recently
from
dfb055c to
93868cb
Compare
I think this name makes more sense, given that this type holds a lazily initialized LRU cache
sccache server disk cache is usually initiated by the first compilation request. If `sccache -s` is issued before then, sccache will not return the currently occupied cache size This PR fixes that
sylvestre
force-pushed
the
always_show_cache
branch
from
93868cb to
dc7243d
Compare
|
Hello, do you need me to do something on this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sccache server disk cache is usually initiated by the first compilation request. If
sccache -sis issued before then, sccache will not return the currently occupied cache size. This PR fixes that by querying the underlying LruDiskCache incurrent_size(). I don't think there are performance implications of this, but I am not sure.I also renamed LazyDiskCache to LazyLruDiskCache, because I think the name is more clear. Let me know if you want me to revert that change