Calculate rustc outputs concurrently with other hashing tasks #2465
+29
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `sccache` invokes `rustc` twice for generating the hash key: once for the inputs and env-deps (`--emit dep-info`), and another time for the output file names (`--print file-names`). However, the latter is invoked only after the former finishes. There is no reason for this dependency. Run `get_compiler_outputs` concurrently with the other `rustc` and hashing tasks in `RustHasher::generate_hash_key`. I initially thought that these two invocations could be merged together, but `--print` stop compilation before the `--emit` is evaluated, so I went with the simpler approach of just running them at the same time.
DaniPopes
force-pushed
the
rustc-outputs
branch
from
9f98505 to
6654b9a
Compare
|
nice Thanks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
=======================================
Coverage 71.22% 71.22%
=======================================
Files 64 64
Lines 35221 35224 +3
=======================================
+ Hits 25087 25090 +3
Misses 10134 10134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I'm not sure how best to add a test here since the behavior is the exact same
I measured the time reported by the Looks about ~5-10ms faster per each However, I couldn't notice a difference in the final walltime of a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
sccacheinvokesrustctwice for generating the hash key: once for the inputs and env-deps (--emit dep-info), and another time for the output file names (--print file-names).However, the latter is invoked only after the former finishes. There is no reason for this dependency.
Run
get_compiler_outputsconcurrently with the otherrustcand hashing tasks inRustHasher::generate_hash_key.I initially thought that these two invocations could be merged together, but
--printstop compilation before the--emitis evaluated, so I went with the simpler approach of just running them at the same time.