Move the bindings into a new uniffi_bindings crate. #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assuming the split makes sense - maybe "uniffi_bindgen" is the correct name for the bindings, and it's the "build a component interface" part that should get a new name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to move the templates and special-casing of the builtin bindings out from uniffi_bindgen.
Eventually, we'd drop all bindings generation from the top-level
unifficrate - you depend and use the specific bindings crate, just like consumers of 3rd-party languages are forced to do now. It helps keep some degree of separation between the bindings and the bindgen crate.OTOH - it's yet another crate to release etc. Is it actually worth it? WDYT?