Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Review #1

Open
wants to merge 2 commits into
base: empty
Choose a base branch
from
Open

Review #1

wants to merge 2 commits into from

Conversation

mpe85
Copy link
Owner

@mpe85 mpe85 commented Feb 17, 2025

General points:

  • The project has a good package structure that separates different concerns (configuration, core/domain, core/respository, core/services, web).
  • Lombok is used to redure boilerplate code.
  • JavaDoc is missing in all places. This would help to understand the purpose of each class and method.
  • API documentation in CouponResource is missing.
  • API security is missing at all.
  • Most dependencies including gradle itself are outdated and should be kept up-to-date to avoid vulnerabilities and bugs.
  • There are unit tests only for the CouponService. Other classes like entities, DTOs, repositories, controllers could be unit testes as well.
  • Other kinds of tests like integration or e2e test are missing at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants