player/command: update speed filters for pitch-correction change too #16948
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would be called on every frame presented, this only needs to be called if display sync was active for the last frame but isn't active anymore. This hid the bug mentioned in mpv-player#16947 if VO was active.
Fixes mpv-player#16947 for both audio only files as well as for files with video which would've been regressed by the previous commit
llyyr
force-pushed
the
pitch-correction-runtime
branch
from
4a30d9d to
878dfa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit regresses #16947 for video files as well, second commit fixes it for both. I can swap the commit order around if preferred