command: react to --force-window changes with no file playing #16958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle_force_window() is called in play_current_file() and run_playloop(), so it is never triggered if you do mpv --idle and then change force-window at runtime. Move the playloop call to the option callbacks to fix this. Fixes mpv-player#16956. Giving the UPDATE_VO flag to --force-window would not fix this due to it having no effect if there's isn't already a window, which prevents the bug described in 544240c. It would also reinit the VO unnecessarily when cycling between force-window yes and immediate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_force_window() is called in play_current_file() and run_playloop(), so it is never triggered if you do mpv --idle and then change force-window at runtime. Move the playloop call to the option callbacks to fix this.
Fixes #16956.
Giving the UPDATE_VO flag to --force-window would not fix this due to it having no effect if there's isn't already a window, which prevents the bug described in 544240c. It would also reinit the VO unnecessarily when cycling between force-window yes and immediate.