Support quoted shebang executable #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the venv path is really long, uv will quote the python3 executable in the shebang and this breaks the `LONG_SHEBANG_REGEX` logic, which results in venv-pack2 not replacing the shebang line in the packed venv. Steps to reproduce: ```shell venv_path=/tmp/this/is/an/absurdly/long/path/to/test/the/shebang/line/at/some/point/it/gets/quoted/in/the/venv/binaries mkdir -p $venv_path python3 -m venv $venv_path source $venv_path/bin/activate python3 -m pip install --upgrade pip uv uv pip install --compile memory_profiler head -2 $venv_path/bin/mprof ``` Outputs this (note the executable path after `exec` is quoted): ```shell #!/bin/sh '''exec' '/private/tmp/this/is/an/absurdly/long/path/to/test/the/shebang/line/at/some/point/it/gets/quoted/in/the/venv/binaries/bin/python3' "$0" "$@" ```
If the venv is created using a symlink (for example, on MacOS /tmp -> /private/tmp) then the 'prefix' (the venv path) will not match the executable in the shebang added by uv, as that will be the resolved path Using `os.path.realpath()` ensures the two paths compared are fully resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the venv path is really long, uv will quote the python3 executable in the shebang and this breaks the
LONG_SHEBANG_REGEXlogic, which results in venv-pack2 not replacing the shebang line in the packed venv.Steps to reproduce:
Outputs this (note the executable path after
execis quoted):This change ensures the optional quotes are supported and are not included as part of the command, ensuring it matches the prefix (venv path) and the shebang gets replaced correctly in the packed venv