Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for nonstandard map key in the decoder #266

Conversation

PejmanNik
Copy link

Adding support for nonstandard map key in the decoder by adding a new callback function in the decoder options that accepts the decoded map key and returns a JS standard map key (string or number)

fix #255

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (1f9e335) to head (59057ee).
Report is 54 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   98.00%   97.28%   -0.73%     
==========================================
  Files          16       17       +1     
  Lines        1102     1140      +38     
  Branches      251      253       +2     
==========================================
+ Hits         1080     1109      +29     
- Misses         22       31       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gfx gfx merged commit bf9c15a into msgpack:main Feb 21, 2025
12 checks passed
@gfx
Copy link
Member

gfx commented Feb 21, 2025

Thank you for your contribution. I like it. LGTM.

@gfx
Copy link
Member

gfx commented Feb 21, 2025

Released v3.1.0 with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing behavior for map key: The type of key must be string or number
3 participants