6838 add prefs repo layer #6885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Priority: Should have
Team Ruru 🦉
noel-yeldos
commented
Mar 10, 2025
jmbrunskill
reviewed
Mar 10, 2025
jmbrunskill
reviewed
Mar 10, 2025
jmbrunskill
reviewed
Mar 10, 2025
jmbrunskill
reviewed
Mar 10, 2025
| #[derive(PartialEq, Debug, Clone, Default)] | ||
| pub struct Preference { | ||
| pub preference_row: PreferenceRow, | ||
| pub store_row: StoreRow, |
There was a problem hiding this comment.
You're not useing this store row for anything, and it's not clear to me that you will need it.
I think probably safer to just remove it for now, and only add it in when it's required for something?
There was a problem hiding this comment.
Updated here: 5bccdaa
Chris-Petty
requested changes
Mar 11, 2025
noel-yeldos
commented
Mar 11, 2025
| } | ||
| } | ||
|
|
||
| pub type PreferenceJoin = (PreferenceRow, StoreRow); |
There was a problem hiding this comment.
Do I need to remove StoreRow here as well?
noel-yeldos
commented
Mar 11, 2025
Comment on lines
+76
to
+97
| let result = final_query | ||
| .load::<PreferenceJoin>(self.connection.lock().connection())? | ||
| .into_iter() | ||
| .map(|(preference_row, _store_row)| Preference { preference_row }) | ||
| .collect(); | ||
|
|
||
| Ok(result) | ||
| } | ||
| } | ||
|
|
||
| type BoxedPreferenceQuery = IntoBoxed<'static, InnerJoin<preference::table, store::table>, DBType>; | ||
|
|
||
| fn create_filtered_query(filter: Option<PreferenceFilter>) -> BoxedPreferenceQuery { | ||
| let mut query = preference::table.inner_join(store::table).into_boxed(); | ||
|
|
||
| if let Some(f) = filter { | ||
| let PreferenceFilter { id } = f; | ||
|
|
||
| apply_equal_filter!(query, id, preference::id); | ||
| } | ||
| query | ||
| } |
There was a problem hiding this comment.
Do I need to remove StoreRow here as well? I thought we needed storeRow to access store_id?
Chris-Petty
approved these changes
Mar 11, 2025
| } | ||
|
|
||
| pub fn delete(&self, preference_id: &str) -> Result<Option<i64>, RepositoryError> { | ||
| let old_row = self.find_one_by_id(preference_id)?; |
There was a problem hiding this comment.
Hey look it came in use! I knew it'd have something to do with sync 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6838
👩🏻💻 What does this PR do?
Add preference to changelogtable and Add repo layer for preference table
💌 Any notes for the reviewer?
🧪 Testing
📃 Documentation
1.
2.
📃 Reviewer Checklist
The PR Reviewer(s) should fill out this section before approving the PR
Breaking Changes
Issue Review
Tests Pass